From dbc251254eba41d6a46efaee1540a2df9fc6ef4a Mon Sep 17 00:00:00 2001 From: Zygmunt Krynicki <zygmunt.krynicki@huawei.com> Date: Fri, 4 Feb 2022 14:21:54 +0000 Subject: [PATCH] many: replace unused argument with _ Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@huawei.com> --- cmd/rauc-custom-boot-handler/cmd.go | 4 ++-- cmd/rauc-custom-boot-handler/cmd_test.go | 4 ++-- cmd/rauc-post-install-handler/cmd.go | 2 +- cmd/rauc-post-install-handler/cmd_test.go | 2 +- cmd/rauc-pre-install-handler/cmd.go | 2 +- cmd/rauc-pre-install-handler/cmd_test.go | 2 +- cmd/sysota-mux/main_test.go | 2 +- cmd/sysotactl/cmd_test.go | 2 +- cmd/sysotad/service_test.go | 2 +- cmd/sysotad/sysotad.go | 2 +- rauc/installhandler/installdbus/client_test.go | 2 +- 11 files changed, 13 insertions(+), 13 deletions(-) diff --git a/cmd/rauc-custom-boot-handler/cmd.go b/cmd/rauc-custom-boot-handler/cmd.go index 7c73a4f..2c97ad2 100644 --- a/cmd/rauc-custom-boot-handler/cmd.go +++ b/cmd/rauc-custom-boot-handler/cmd.go @@ -129,7 +129,7 @@ func (cmd setPrimarySlotCmd) OneLiner() string { return "set the name of the primary slot" } -func (cmd setPrimarySlotCmd) Run(ctx context.Context, args []string) error { +func (cmd setPrimarySlotCmd) Run(_ context.Context, args []string) error { var slot boot.Slot switch len(args) { @@ -192,7 +192,7 @@ func (cmd setSlotStateCmd) OneLiner() string { return "set the state of a given slot" } -func (cmd setSlotStateCmd) Run(ctx context.Context, args []string) error { +func (cmd setSlotStateCmd) Run(_ context.Context, args []string) error { var slot boot.Slot var state boot.SlotState diff --git a/cmd/rauc-custom-boot-handler/cmd_test.go b/cmd/rauc-custom-boot-handler/cmd_test.go index f465f64..bd4a355 100644 --- a/cmd/rauc-custom-boot-handler/cmd_test.go +++ b/cmd/rauc-custom-boot-handler/cmd_test.go @@ -61,7 +61,7 @@ func (s *cmdSuite) EnsureConn(c *C) *dbus.Conn { return s.conn } -func (s *cmdSuite) SetUpTest(c *C) { +func (s *cmdSuite) SetUpTest(_ *C) { s.handler.ResetCallbacks() } @@ -178,7 +178,7 @@ type suiteBase struct { cmd cmdr.Cmd } -func (s *suiteBase) SetUpTest(c *C) { +func (s *suiteBase) SetUpTest(_ *C) { s.handler.ResetCallbacks() s.cmd = rauccustomboothandler.InterfaceCmd{&s.handler} } diff --git a/cmd/rauc-post-install-handler/cmd.go b/cmd/rauc-post-install-handler/cmd.go index c150973..983d7ed 100644 --- a/cmd/rauc-post-install-handler/cmd.go +++ b/cmd/rauc-post-install-handler/cmd.go @@ -32,7 +32,7 @@ func (cmd Cmd) OneLiner() string { } // Run constructs handler context and invokes the post-install method over D-Bus. -func (cmd Cmd) Run(ctx context.Context, args []string) error { +func (cmd Cmd) Run(_ context.Context, _ []string) error { return installdbus.Do(func(client *installdbus.Client, env *installhandler.Environment) error { return client.PostInstall(env) }) diff --git a/cmd/rauc-post-install-handler/cmd_test.go b/cmd/rauc-post-install-handler/cmd_test.go index 184c815..808bbdf 100644 --- a/cmd/rauc-post-install-handler/cmd_test.go +++ b/cmd/rauc-post-install-handler/cmd_test.go @@ -34,7 +34,7 @@ type cmdSuite struct { var _ = Suite(&cmdSuite{}) -func (s *cmdSuite) SetUpTest(c *C) { +func (s *cmdSuite) SetUpTest(_ *C) { s.cmd = raucpostinstallhandler.Cmd{} } diff --git a/cmd/rauc-pre-install-handler/cmd.go b/cmd/rauc-pre-install-handler/cmd.go index 54aca46..438f0fe 100644 --- a/cmd/rauc-pre-install-handler/cmd.go +++ b/cmd/rauc-pre-install-handler/cmd.go @@ -32,7 +32,7 @@ func (cmd Cmd) OneLiner() string { } // Run constructs handler context and invokes the pre-install method over D-Bus. -func (cmd Cmd) Run(ctx context.Context, args []string) error { +func (cmd Cmd) Run(_ context.Context, _ []string) error { return installdbus.Do(func(client *installdbus.Client, env *installhandler.Environment) error { return client.PreInstall(env) }) diff --git a/cmd/rauc-pre-install-handler/cmd_test.go b/cmd/rauc-pre-install-handler/cmd_test.go index 4de9200..03c655e 100644 --- a/cmd/rauc-pre-install-handler/cmd_test.go +++ b/cmd/rauc-pre-install-handler/cmd_test.go @@ -34,7 +34,7 @@ type cmdSuite struct { var _ = Suite(&cmdSuite{}) -func (s *cmdSuite) SetUpTest(c *C) { +func (s *cmdSuite) SetUpTest(_ *C) { s.cmd = raucpreinstallhandler.Cmd{} } diff --git a/cmd/sysota-mux/main_test.go b/cmd/sysota-mux/main_test.go index f8d28f0..a2d8e46 100644 --- a/cmd/sysota-mux/main_test.go +++ b/cmd/sysota-mux/main_test.go @@ -16,6 +16,6 @@ type mainSuite struct{} var _ = Suite(&mainSuite{}) -func (s *mainSuite) TestMain(c *C) { +func (s *mainSuite) TestMain(_ *C) { main.Main() } diff --git a/cmd/sysotactl/cmd_test.go b/cmd/sysotactl/cmd_test.go index 83f94b3..0f24e6c 100644 --- a/cmd/sysotactl/cmd_test.go +++ b/cmd/sysotactl/cmd_test.go @@ -97,7 +97,7 @@ func (s *cmdSuite) TearDownSuite(c *C) { s.Suite.TearDownSuite(c) } -func (s *cmdSuite) SetUpTest(c *C) { +func (s *cmdSuite) SetUpTest(_ *C) { s.m.Lock() defer s.m.Unlock() diff --git a/cmd/sysotad/service_test.go b/cmd/sysotad/service_test.go index dcd549d..9d5c1c0 100644 --- a/cmd/sysotad/service_test.go +++ b/cmd/sysotad/service_test.go @@ -61,7 +61,7 @@ func (s *serviceSuite) EnsureService(c *C) { } } -func (s *serviceSuite) SetUpTest(c *C) { +func (s *serviceSuite) SetUpTest(_ *C) { s.config = ota.Config{} s.state = ota.SystemState{} } diff --git a/cmd/sysotad/sysotad.go b/cmd/sysotad/sysotad.go index a282ef6..65d0244 100644 --- a/cmd/sysotad/sysotad.go +++ b/cmd/sysotad/sysotad.go @@ -47,7 +47,7 @@ func (Cmd) OneLiner() string { } // Run implements the sysotad binary. -func (cmd *Cmd) Run(ctx context.Context, args []string) (err error) { +func (cmd *Cmd) Run(ctx context.Context, _ []string) (err error) { _, stdout, _ := cmdr.Stdio(ctx) // Connect to the system bus and defer disconnect on return. diff --git a/rauc/installhandler/installdbus/client_test.go b/rauc/installhandler/installdbus/client_test.go index d663d38..0f1d0eb 100644 --- a/rauc/installhandler/installdbus/client_test.go +++ b/rauc/installhandler/installdbus/client_test.go @@ -35,7 +35,7 @@ type clientSuite struct { var _ = Suite(&clientSuite{}) -func (s *clientSuite) SetUpTest(c *C) { +func (s *clientSuite) SetUpTest(_ *C) { s.handler.ResetCallbacks() } -- GitLab