From cb0b857399eb82a98eb87d77b7ea6c2cfb92376d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bernhard=20Rosenkr=C3=A4nzer?=
 <bernhard.rosenkraenzer.ext@huawei.com>
Date: Fri, 3 Sep 2021 16:01:45 +0200
Subject: [PATCH] ncurses: remove -Werror=format-nonliteral from compiler flags
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

ncurses' termcap to terminfo converter uses a non-literal
format string.
This has been verified to be harmless in 6.2 (the "unsafe"
use of sscanf happens only with hardcoded, safe strings).

Removing -Werror=format-nonliteral here allows us to use
-Werror=format-nonliteral globally in OPTIMIZE_FOR=security mode
while keeping ncurses building.

Signed-off-by: Bernhard Rosenkränzer <bernhard.rosenkraenzer.ext@huawei.com>
---
 .../recipes-core/ncurses/ncurses_%.bbappend         | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 meta-ohos-core/recipes-core/ncurses/ncurses_%.bbappend

diff --git a/meta-ohos-core/recipes-core/ncurses/ncurses_%.bbappend b/meta-ohos-core/recipes-core/ncurses/ncurses_%.bbappend
new file mode 100644
index 00000000..208b4115
--- /dev/null
+++ b/meta-ohos-core/recipes-core/ncurses/ncurses_%.bbappend
@@ -0,0 +1,13 @@
+# SPDX-FileCopyrightText: Huawei Inc.
+# SPDX-License-Identifier: Apache-2.0
+
+# ncurses' termcap to terminfo converter uses a non-literal
+# format string.
+# This has been verified to be harmless in 6.2 (the "unsafe"
+# use of sscanf happens only with hardcoded, safe strings).
+#
+# Removing -Werror=format-nonliteral here allows us to use
+# -Werror=format-nonliteral globally in OPTIMIZE_FOR=security mode
+# while keeping ncurses building.
+
+TARGET_CFLAGS_remove = "-Werror=format-nonliteral"
-- 
GitLab