From 6b4d14bfb948871450097bb60b2a8857c475f24f Mon Sep 17 00:00:00 2001
From: Pavel Zhukov <pavel.zhukov@huawei.com>
Date: Thu, 23 Jun 2022 22:07:57 +0200
Subject: [PATCH] sysota: force external linking with clang

When sysota is built with toolchain-clang broken dynamicaly linked
binary file is produced [1] if shared linking (GO_DYNLINK) is disabled.
As the result strip phase of do_packages fails with [2]
Sysota is built with disabled shared linking because of another bug [3]
The problem with stripping can be fixed with specifying external linker
for clang toolchain (by default Go swutched to internal linker on 64bit
arches if -pie has been specified since version 1.15 [4] ).
Limiting this change to clang only to be safe.

[1] **readelf: Error: no .dynamic section in the dynamic segment**

[2] Subprocess output:x86_64-oniro-linux-llvm-strip: error: SHT_STRTAB
        string table section [index 7] is non-null terminated

[3] https://gitlab.eclipse.org/eclipse/oniro-core/sysota/-/issues/7

[4] https://go.dev/doc/go1.15#linker

Fixes: #624

Signed-off-by: Pavel Zhukov <pavel.zhukov@huawei.com>
---
 meta-oniro-core/recipes-core/sysota/sysota_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oniro-core/recipes-core/sysota/sysota_git.bb b/meta-oniro-core/recipes-core/sysota/sysota_git.bb
index 99307391..d5e2aa35 100644
--- a/meta-oniro-core/recipes-core/sysota/sysota_git.bb
+++ b/meta-oniro-core/recipes-core/sysota/sysota_git.bb
@@ -19,6 +19,7 @@ GO_DYNLINK:x86 = ""
 GO_DYNLINK:x86-64 = ""
 GO_DYNLINK:arm = ""
 GO_DYNLINK:aarch64 = ""
+GO_LINKMODE:toolchain-clang  ?= "-linkmode external"
 
 # This package is built with go-mod as well as with make.
 #
-- 
GitLab