Skip to content

FileHandler tests improved

Eclipse Webmaster requested to merge github/fork/osbornjd/jay/MarkIII into jay/MarkIII

Created by: osbornjd

Summary

This PR addresses the issues 392, 394, 398, 400, 401, and 402. Most of these are small changes, but a few details about more significant changes are described below.

Changes in FileHandler

The main issue resolved is that FileHandler now returns a Command which the user tells to execute, rather than the execution being performed in the constructor of a CopyFile or MoveFile Command.

FileHandlerTest also now creates and destroys temporary test files.

Logger

A logger was also added to replace the System.out print statements. The logger prints to the console as defined by a very basic default log4j.properties file that was added to the resources directory. This directory is by default included in the classpath so the maven project picks it up and applies it at run time (e.g. in CommandFactoryTest).

Merge request reports