ice merge requestshttps://gitlab.eclipse.org/eclipse/ice/ice/-/merge_requests2019-11-05T21:13:02Zhttps://gitlab.eclipse.org/eclipse/ice/ice/-/merge_requests/411ConnectionManager and Associated Connections2019-11-05T21:13:02ZEclipse WebmasterConnectionManager and Associated Connections*Created by: osbornjd*
I'm going to introduce this PR now since I think it would be useful to review the code associated with connections and get comments on it as a "first step" towards filling out the rest of the remote commands.
...*Created by: osbornjd*
I'm going to introduce this PR now since I think it would be useful to review the code associated with connections and get comments on it as a "first step" towards filling out the rest of the remote commands.
This PR introduces some code that manages remote connections. There are three main classes, ConnectionConfiguration, Connection, and ConnectionManager which is a static factory. ConnectionManager is responsible for opening, closing, and in general managing the various remote connections that one might open. ConnectionConfiguration and Connection are the two classes which contain all of the relevant information necessary for establishing/holding/closing a remote ssh connection.
At the moment, the test for ConnectionManager just tests the ability to successfully open and close an ssh connection with a private (to me) ssh connection. I am planning on making this more general so that tests can be run by anyone without giving away personal ssh credentials. https://gitlab.eclipse.org/eclipse/ice/ice/-/merge_requests/385Initial Commands API2019-08-20T00:40:52ZEclipse WebmasterInitial Commands API*Created by: osbornjd*
This PR introduces a basic class structure for the Commands API, which is being rewritten as discussed in [issue 384](https://github.com/eclipse/ice/issues/384).*Created by: osbornjd*
This PR introduces a basic class structure for the Commands API, which is being rewritten as discussed in [issue 384](https://github.com/eclipse/ice/issues/384).https://gitlab.eclipse.org/eclipse/ice/ice/-/merge_requests/457New Tasks infrastructure to replace Item2020-10-22T21:37:00ZEclipse WebmasterNew Tasks infrastructure to replace Item*Created by: jayjaybillings*
The Tasks library will replace the Item from 2.0. Documentation is included. Test coverage is ~84.0%*Created by: jayjaybillings*
The Tasks library will replace the Item from 2.0. Documentation is included. Test coverage is ~84.0%https://gitlab.eclipse.org/eclipse/ice/ice/-/merge_requests/408Overhaul of FileHandler Design2019-09-05T15:29:37ZEclipse WebmasterOverhaul of FileHandler Design*Created by: osbornjd*
## Summary
This PR introduces an overhaul of the FileHandler design and functionality. The overall design is cleaner and largely hidden from the user. There are still some areas of functionality that need to be w...*Created by: osbornjd*
## Summary
This PR introduces an overhaul of the FileHandler design and functionality. The overall design is cleaner and largely hidden from the user. There are still some areas of functionality that need to be worked out with remote file transfers, but these can be addressed once the remote command API is finished.
This PR addresses issue [404](https://github.com/eclipse/ice/issues/404).
### Brief Overview of Design
The FileHandler design now operates as follows:
1. A factory IFileHandlerFactory creates a concrete instance of a Local or Remote FileHandler, which inherits from the abstract class FileHandler. FileHandler implements the interface IFileHandler, which describes the overall layout of the FileHandler design.
- Note that at the moment, IFileHandlerFactory just creates a LocalFileHandler. RemoteFileHandling will be addressed once RemoteCommands have been implemented.
2. The concrete instance of Local/Remote FileHandler then creates a concrete instance of a MoveFileCommand or CopyFileCommand, depending on which file transfer command was called.
3. FileHandler then calls the Command to execute which actually executes the the file transfer. A CommandStatus is passed up the chain to the original call by the user to copy/move a file to confirm that the transfer was completed successfully.
### Other Changes Unrelated to FileHandler
A few changes were made that were unrelated to the FileHandler
1. The comment structure for the getter/setter functions in CommandConfiguration was adjusted to meet the eclipse style.
2. A test in TestCommandFactory was adjusted so that the working directory can be identified on a user's computer and the test script can then be run without absolute paths being specified.