Signed-off-by: arbennett <bennettar@ornl.gov>

This reverts commit 17c16776.

This reverts commit 17c16776.

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

that prevented the bundle from loading and blocked the ICE perspective.

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

[470844]MeshAppState floating point equality checking repaired

470915]Applied Short Circuit Logic MasterDetailsComponent

[470838]Correcting NekWriter to generic linebreaks

[470835]Applied Short Circuit Logic in ToolItemMenuListener

[470833]Cleaning up needless code

MasterDetailsComponent now uses short circuit comparisions instead of
eager ones. Thus, it will now only evaulate expressions in an AND until
one evaluates to false, instead of evaluating all of them.

Bug: 470915 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470915


Signed-off-by: Robert Smith <SmithRW@ornl.gov>

MeshAppState no longer directly tests for the equality of two floating
point numbers. It instead properly takes the absolute value of their
difference and compares it to a small delta value.

Bug: 470844 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470844


Signed-off-by: Robert Smith <SmithRW@ornl.gov>

NewWriter has been changed to utilize system-agnostic linebreak
characters instead of hardcoded values for. Files created this way have
been confirmed to be formatted correctly under both Linux and Windows.

Bug: 470838 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470838


Signed-off-by: Robert Smith <SmithRW@ornl.gov>

An instance of ToolItemMenuListener using eager logic instead of short
circuit logic in comparision has been changed. The conditional statement
will now only evaulate the secondary statement if the first returned
false.

Bug: 470835 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470835


Signed-off-by: Robert Smith <SmithRW@ornl.gov>

CoreConnectDialog's createDialogArea method contianed unneccesary code
taking the logical OR of a value with itself. This has been removed.

Bug: 470833 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470833


Signed-off-by: Robert Smith <SmithRW@ornl.gov>

master in.

Signed-off-by: arbennett <bennettar@ornl.gov>

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

Signed-off-by: Jordan Deyton <deytonjh@ornl.gov>

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

many overridden methods with non-javadoc comments (in cases where the
override changes behavior, I left the existing documentation, but things
like equals or hashcode don't need duplicate documentation).

Signed-off-by: Jordan Deyton <deytonjh@ornl.gov>

Signed-off-by: arbennett <bennettar@ornl.gov>

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

folder includes only files generated by SonarQube builds.

Signed-off-by: Jordan Deyton <deytonjh@ornl.gov>

Signed-off-by: arbennett <bennettar@ornl.gov>

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

Signed-off-by: arbennett <bennettar@ornl.gov>

bundle.

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

Conflicts:
	src/org.eclipse.ice.materials.ui/src/org/eclipse/ice/materials/ui/AddMaterialWizardPage.java
	src/org.eclipse.ice.materials.ui/src/org/eclipse/ice/materials/ui/MaterialsDatabaseMasterDetailsBlock.java

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

Conflicts:
	src/org.eclipse.ice.materials.ui/src/org/eclipse/ice/materials/ui/AddMaterialWizardPage.java
	src/org.eclipse.ice.materials.ui/src/org/eclipse/ice/materials/ui/MaterialsDatabaseContentProvider.java
	src/org.eclipse.ice.materials.ui/src/org/eclipse/ice/materials/ui/MaterialsDatabaseMasterDetailsBlock.java

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

org.eclipse.remote interfaces. It checks for existing connections, which
are saved to preferences, or creates a new connection if none are
available. The new remote stuff also pops up a secure storage password
dialog, so that's something we'll have to look at. 

This implementation also grabs the actual Service reference, we need to
investigate grabbing it from DS if possible. 

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

fixes build failures that occur only while running the maven build.

Signed-off-by: Jordan Deyton <deytonjh@ornl.gov>

Signed-off-by: Jordan Deyton <deytonjh@ornl.gov>

Also made minor changes to the ReflectivityModel on the way to having
all the parameters added.

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

jay/reflectivity

Conflicts:
	src/org.eclipse.ice.reflectivity/src/org/eclipse/ice/reflectivity/ReflectivityModel.java

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

JobLauncherForm where an Entry was improperly overriding setup().

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>

Implemented Stoichiometry calculations. Finished up Materials Database.