Commit d8681ed2 authored by Robert Smith's avatar Robert Smith
Browse files

Fixed DefaultPageFactory for GeometryComponents

The DefaultPageFactory was trying to cast a DefaultPageFactory to an
IPageProvider when creating pages for a GeometryComponent. I copied the
code for the getMeshComponentPages() function to create output that
seems to work (ie creates a Geometry Editor when run in ICE)
Signed-off-by: Robert Smith's avatarRobert Smith <>
parent ffda5856
......@@ -20,6 +20,7 @@ import org.eclipse.e4.core.contexts.IEclipseContext;
......@@ -219,23 +220,28 @@ public class DefaultPageFactory implements IPageFactory {
public ArrayList<IFormPage> getGeometryComponentPages(FormEditor editor,
ArrayList<Component> components) {
// List for storing the pages
// List for the pages
ArrayList<IFormPage> pages = new ArrayList<IFormPage>();
IPageProvider provider = null;
String contextKey = components.get(0).getContext();
// Get the appropriate page provider if indicated and available in the
// e4 context
if (context.containsKey(contextKey)) {
provider = (IPageProvider) context.get(contextKey);
} else {
// Otherwise fall back to the default
provider = new DefaultGeometryPageProvider();
try {
// Create the provider and get the pages from it
ArrayList<IGeometryPageProvider> GeometryComponentPages = IGeometryPageProvider
if (GeometryComponentPages != null && GeometryComponentPages.size() > 0) {
// Use the default error page provider
String providerNameToUse = DefaultErrorPageProvider.PROVIDER_NAME;
// Do a linear search to find the correct provider
for (IGeometryPageProvider currentProvider : GeometryComponentPages) {
if (providerNameToUse.equals(currentProvider.getName())) {
pages = currentProvider.getPages(editor, components);
} else {
logger.error("No GeometryComponentPages registered");
} catch (CoreException e) {
logger.error("Unable to get GeometryComponentPages", e);
// Get the pages
pages = provider.getPages(editor, components);
return pages;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment