Commit 27a0577b authored by Robert Smith's avatar Robert Smith

Removed return value from openView()

AbstractWorbenchTester's openView() no longer returns a reference to the
opened view, to avoid a bug where SWTBot could not obtain that
reference.
Signed-off-by: Robert Smith's avatarRobert Smith <smithrw@ornl.gov>
parent 8672b30d
...@@ -22,7 +22,6 @@ import org.eclipse.ice.datastructures.resource.ICEResource; ...@@ -22,7 +22,6 @@ import org.eclipse.ice.datastructures.resource.ICEResource;
import org.eclipse.ice.datastructures.resource.VizResource; import org.eclipse.ice.datastructures.resource.VizResource;
import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Display;
import org.eclipse.swtbot.eclipse.finder.SWTWorkbenchBot; import org.eclipse.swtbot.eclipse.finder.SWTWorkbenchBot;
import org.eclipse.swtbot.eclipse.finder.widgets.SWTBotView;
import org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException; import org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException;
import org.eclipse.swtbot.swt.finder.utils.SWTBotPreferences; import org.eclipse.swtbot.swt.finder.utils.SWTBotPreferences;
import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorInput;
...@@ -267,7 +266,7 @@ public abstract class AbstractWorkbenchTester ...@@ -267,7 +266,7 @@ public abstract class AbstractWorkbenchTester
* seen in the plug-in extensions and the UI itself. * seen in the plug-in extensions and the UI itself.
* @return The view wrapped by the {@code SWTBot}. * @return The view wrapped by the {@code SWTBot}.
*/ */
protected SWTBotView openView(String category, String name) { protected void openView(String category, String name) {
SWTWorkbenchBot bot = getBot(); SWTWorkbenchBot bot = getBot();
...@@ -281,8 +280,6 @@ public abstract class AbstractWorkbenchTester ...@@ -281,8 +280,6 @@ public abstract class AbstractWorkbenchTester
bot.tree().expandNode(category, false).select(name); bot.tree().expandNode(category, false).select(name);
// Close the dialog by clicking OK. // Close the dialog by clicking OK.
bot.button().click(); bot.button().click();
// Return the view itself.
return bot.viewByTitle(name);
} }
/** /**
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment