Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E escet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • Eclipse ESCET (Supervisory Control Engineering Toolkit)
  • escet
  • Merge requests
  • !374

#417 Support dark theme in ESCET (console/legend/plotviz/checkstyle)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dennis Hendriks requested to merge 417-support-dark-theme-in-escet into develop Sep 25, 2022
  • Overview 21
  • Commits 8
  • Pipelines 2
  • Changes 6

The first 4 dark theme changes for #417 (closed):

  • Add application framework console dark theme support:

    • Different colors for light and dark theme.
    • Keeps same colors for light theme as used before.
    • Adapts to theme changes, even after application termination.
  • Application status legend dialog improvements for dark theme:

    • 'Composite' with grid layout rather than a 'Tree'.
    • No more custom background color configuration.
  • Added CIF simulator plot visualizer dark theme support:

    • Plot visualizer automatically applies light or dark theme.
    • Plot visualizer automatic theme switch upon Eclipse theme change.
    • Plot visualizer even changes theme after simulator has ended.
    • Light theme now implemented as a separate class.
      • Still based on the XChart's 'MatlabTheme'.
    • Added dark theme, extending light theme.
  • ESCET development environment Checkstyle warning style change:

    • Current yellow background does not play well with dark theme.
      • On dark theme, blue/green text on yellow background is hard to read.
      • Does not affect ESCET product, nor affects end users.
    • Changed style to vertical bar rather than whole line becoming yellow.
      • New style is less obtrusive, and works well on light and dark theme.
      • Kept color the same.

I recommend reviewing per commit.

Addresses #417 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 417-support-dark-theme-in-escet

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent