#1163 CIF type checker: add warning for variables that are effectively constant
requested to merge 1163-cif-type-checker-warn-about-effectively-constant-discrete-variables into develop
- Best to review per commit.
- There are no false positives. There can be false negatives, since it doesn't detect all cases, like a variable initialized to
2and getting assigned1 + 1. - I changed the existing type checker tests to not get new warnings. It took quite some time. I therefore didn't do it for the nearly 600 other tests that do get new warnings. It would take way too much time to go prevent them one by one.
Closes #1163 (closed)