#458 CIF/BDD bit vectors: rename non-negative classes, move classes to sub-package, introduce common base classes
- Next step in #458.
- Best to review per commit.
- No end-user visible changes.
- Changes:
- Renamed
CifBddBitVector*
toNonNegativeCifBddBitVector*
and then toUnsignedCifBddBitVector*
. Also adapted class JavaDocs where needed. - Moved bit vector classes and tests to new
bitvectors
sub-package. - Introduced common
CifBddBitVector
base class. It has the common fields and methods of all bit vectors. Moved them bit by bit over many commits. - Introduced common
CifBddBitVectorAndCarry
base class. It has the common fields and methods of all bit vector and carry classes. Moved them in one go. - Fixed
TwosComplementCifBddBitVector
constructor JavaDoc. - For
UnsignedCifBddBitVector
, thegetInt
andgetLong
methods now returnInteger
andLong
values rather thanint
andlong
, withnull
being returned instead of-1
if the value is non-constant. -
UnsignedCifBddBitVector
now also implementsabs
. -
UnsignedCifBddBitVector
doesn't supportnegate
. - Fixed
UnsignedCifBddBitVectorTest.testResizeWithInvalidLength
test: it failed oncreate
rather thanresize
(it effectively tested the wrong method). - Added
TwosComplementCifBddBitVector.createFromNonNegativeBitVector
. - Renamed
CifBddBitVector.setBits
toCifBddBitVector.setBitsToValue
. - Improved
CifBddBitVector.replaceBy
JavaDoc. - Improve bit vector 'createFromDomain'/'setDomain' methods: improved JavaDocs, improved consistency between the methods, and preconditions are now checked.
- TwosComplementCifBddBitVector: improved
createFrom*
methods: improved JavaDoc/comments, improved parameter/variable names. - Extended the
testCreateFromUnsignedBitVector
test.
- Renamed
Addresses #458
Edited by Dennis Hendriks