#458 CIF/BDD bit vectors: rename non-negative classes, move classes to sub-package, introduce common base classes
- Next step in #458 (closed).
- Best to review per commit.
- No end-user visible changes.
- Changes:
- Renamed
CifBddBitVector*toNonNegativeCifBddBitVector*and then toUnsignedCifBddBitVector*. Also adapted class JavaDocs where needed. - Moved bit vector classes and tests to new
bitvectorssub-package. - Introduced common
CifBddBitVectorbase class. It has the common fields and methods of all bit vectors. Moved them bit by bit over many commits. - Introduced common
CifBddBitVectorAndCarrybase class. It has the common fields and methods of all bit vector and carry classes. Moved them in one go. - Fixed
TwosComplementCifBddBitVectorconstructor JavaDoc. - For
UnsignedCifBddBitVector, thegetIntandgetLongmethods now returnIntegerandLongvalues rather thanintandlong, withnullbeing returned instead of-1if the value is non-constant. -
UnsignedCifBddBitVectornow also implementsabs. -
UnsignedCifBddBitVectordoesn't supportnegate. - Fixed
UnsignedCifBddBitVectorTest.testResizeWithInvalidLengthtest: it failed oncreaterather thanresize(it effectively tested the wrong method). - Added
TwosComplementCifBddBitVector.createFromNonNegativeBitVector. - Renamed
CifBddBitVector.setBitstoCifBddBitVector.setBitsToValue. - Improved
CifBddBitVector.replaceByJavaDoc. - Improve bit vector 'createFromDomain'/'setDomain' methods: improved JavaDocs, improved consistency between the methods, and preconditions are now checked.
- TwosComplementCifBddBitVector: improved
createFrom*methods: improved JavaDoc/comments, improved parameter/variable names. - Extended the
testCreateFromUnsignedBitVectortest.
- Renamed
Addresses #458 (closed)
Edited by Dennis Hendriks