From 608963e93c823bfdc4bc15503b3c2bddbcb98628 Mon Sep 17 00:00:00 2001
From: Antoni Olivier <olivier.antoni@cea.fr>
Date: Tue, 15 Apr 2025 16:59:21 +0200
Subject: [PATCH] Fix loss derivative
---
src/loss/classification/BCE.cpp | 2 +-
src/loss/regression/MSE.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/loss/classification/BCE.cpp b/src/loss/classification/BCE.cpp
index d80dd27..722184e 100644
--- a/src/loss/classification/BCE.cpp
+++ b/src/loss/classification/BCE.cpp
@@ -123,7 +123,7 @@ Aidge::Tensor Aidge::loss::BCE(std::shared_ptr<Tensor>& prediction,
// Define node: gradient
const std::shared_ptr<Node> gradient_node = Mul("gradient");
div1_node->addChild(gradient_node, 0, 0);
- Producer(std::make_shared<Tensor>(Array1D<float, 1>{{-1.0f/float(target->dims()[0])}}))
+ Producer(std::make_shared<Tensor>(Array1D<float, 1>{{-1.0f/float(target->size())}}))
->addChild(gradient_node, 0, 1);
// Create GraphView
diff --git a/src/loss/regression/MSE.cpp b/src/loss/regression/MSE.cpp
index f6ad9cf..b82eab8 100644
--- a/src/loss/regression/MSE.cpp
+++ b/src/loss/regression/MSE.cpp
@@ -83,7 +83,7 @@ Aidge::Tensor Aidge::loss::MSE(std::shared_ptr<Tensor>& prediction,
// Note: this assume target is [nbBatch, nbChan]
Producer(std::make_shared<Tensor>(
- Array1D<float, 1>{{2 / float(target->dims()[0])}}))
+ Array1D<float, 1>{{2 / float(target->size())}}))
->addChild(mul_node, 0, 1);
sub_node->addChild(mul_node, 0, 0); // Error computation branch !
--
GitLab