From b76944f71911b9b111c878c96d8181f6b397312f Mon Sep 17 00:00:00 2001 From: Antoni Olivier <olivier.antoni@cea.fr> Date: Tue, 25 Jun 2024 16:01:31 +0200 Subject: [PATCH] Fix Adam optimizer unit test --- unit_tests/optimizer/Test_Adam.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unit_tests/optimizer/Test_Adam.cpp b/unit_tests/optimizer/Test_Adam.cpp index d703c41..ef2d521 100644 --- a/unit_tests/optimizer/Test_Adam.cpp +++ b/unit_tests/optimizer/Test_Adam.cpp @@ -119,9 +119,9 @@ TEST_CASE("[learning/Adam] update", "[Optimizer][Adam]") { REQUIRE(approxEq<float,float>(tmpt2, tmpt1, 1e-5f, 1e-8f)); } - // truth for (std::size_t step = 0; step < 10; ++step) { - float lr2 = lr * std::sqrt(1.0f - std::pow(beta1, step + 1)) / (1.0f - std::pow(beta1, step + 1)); + // truth + float lr2 = lr * std::sqrt(1.0f - std::pow(beta2, step + 1)) / (1.0f - std::pow(beta1, step + 1)); float epsilon2 = epsilon * std::sqrt(1.0f - std::pow(beta2, step + 1)); for (std::size_t t = 0; t < nb_tensors; ++t) { for (std::size_t i = 0; i < size_tensors[t]; ++i) { -- GitLab