From edeb04c4ca8deb304a8db8e3f401d2c4615447a6 Mon Sep 17 00:00:00 2001
From: hrouis <houssemeddine.rouis92@gmail.com>
Date: Thu, 25 Jan 2024 15:06:00 +0100
Subject: [PATCH] add consts
---
src/operator/Gather.cpp | 8 ++++----
src/operator/Reshape.cpp | 4 ++--
src/operator/Slice.cpp | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/operator/Gather.cpp b/src/operator/Gather.cpp
index 2bba696e9..3eafe99ef 100644
--- a/src/operator/Gather.cpp
+++ b/src/operator/Gather.cpp
@@ -27,12 +27,12 @@ void Aidge::Gather_Op::computeOutputDims() {
}
std::vector<DimSize_t> outDims = getInput(0)->dims();
- std::vector<DimSize_t> gatheredShape = this->template getAttr<GatherAttr::GatheredShape>();
+ const std::vector<DimSize_t> gatheredShape = this->template getAttr<GatherAttr::GatheredShape>();
// TODO: check indices and gatheredShape
- std::int64_t axisIdx = this->template getAttr<GatherAttr::Axis>() >= 0 ?
- this->template getAttr<GatherAttr::Axis>() :
- this->template getAttr<GatherAttr::Axis>() + outDims.size();
+ const std::int64_t axisIdx = this->template getAttr<GatherAttr::Axis>() >= 0 ?
+ this->template getAttr<GatherAttr::Axis>() :
+ this->template getAttr<GatherAttr::Axis>() + outDims.size();
outDims.erase(outDims.begin() + static_cast<std::size_t>(axisIdx));
if (!gatheredShape.empty())
{
diff --git a/src/operator/Reshape.cpp b/src/operator/Reshape.cpp
index b0eea3c1f..65a9a6319 100644
--- a/src/operator/Reshape.cpp
+++ b/src/operator/Reshape.cpp
@@ -25,7 +25,7 @@ void Aidge::Reshape_Op::computeOutputDims() {
AIDGE_THROW_OR_ABORT(std::runtime_error, "Input was not connected");
}
- DimSize_t nbOutDims = this->template getAttr<ReshapeAttr::Shape>().size();
+ const DimSize_t nbOutDims = this->template getAttr<ReshapeAttr::Shape>().size();
std::vector<DimSize_t> outDims;
std::size_t outSize = 1;
for(std::size_t i=0; i<nbOutDims; ++i)
@@ -33,7 +33,7 @@ void Aidge::Reshape_Op::computeOutputDims() {
int dimSize = this->template getAttr<ReshapeAttr::Shape>()[i];
if (dimSize < 1)
{
- AIDGE_THROW_OR_ABORT(std::runtime_error, "bad dimension value");
+ AIDGE_THROW_OR_ABORT(std::runtime_error, "Bad dimension value");
}
outDims.push_back(dimSize);
outSize *= dimSize;
diff --git a/src/operator/Slice.cpp b/src/operator/Slice.cpp
index 40f74adfb..a0336c39b 100644
--- a/src/operator/Slice.cpp
+++ b/src/operator/Slice.cpp
@@ -30,7 +30,7 @@ void Aidge::Slice_Op::computeOutputDims() {
AIDGE_THROW_OR_ABORT(std::runtime_error, "Every input should be associated with a Tensor");
}
- DimSize_t nbAxes = this->template getAttr<SliceAttr::Axes>().size();
+ const DimSize_t nbAxes = this->template getAttr<SliceAttr::Axes>().size();
std::vector<DimSize_t> outDims = getInput(0)->dims();
for (std::size_t i = 0; i < nbAxes; ++i) {
// For each slice operation get the params and cast them to size_t
--
GitLab