From da2a7e8f217c6c63efd73dedfe30f92b082230c9 Mon Sep 17 00:00:00 2001
From: Olivier BICHLER <olivier.bichler@cea.fr>
Date: Wed, 6 Sep 2023 17:55:42 +0200
Subject: [PATCH] Temporary workaround for private members access
---
include/aidge/graph/Node.hpp | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/aidge/graph/Node.hpp b/include/aidge/graph/Node.hpp
index 3f347f386..cc2da0fd8 100644
--- a/include/aidge/graph/Node.hpp
+++ b/include/aidge/graph/Node.hpp
@@ -33,7 +33,8 @@ class GraphView;
* @brief Object carrying the topological information of the computational graph.
*/
class Node : public std::enable_shared_from_this<Node> {
-private:
+//private:
+public: // TODO: workaround to make GraphView:clone() work, friend doesn't work because of forward declaration
struct weakCompare {
bool operator()(const std::weak_ptr<Aidge::GraphView>& a, const std::weak_ptr<Aidge::GraphView>& b) const {
// Compare the content of the weak_ptrs
@@ -399,7 +400,8 @@ public:
return node->clone();
}
- friend std::shared_ptr<GraphView> GraphView::clone(NodePtr(*cloneNode)(NodePtr)) const;
+ // TODO: does not work, friend requires full definition, but there is a circular dependency between Node and GraphView
+ //friend std::shared_ptr<GraphView> GraphView::clone(NodePtr(*cloneNode)(NodePtr)) const;
private:
///////////////////////////////////////////////////////
--
GitLab