From b3c74bba91d975bd20f0018570b579f647984d96 Mon Sep 17 00:00:00 2001
From: Olivier BICHLER <olivier.bichler@cea.fr>
Date: Thu, 12 Sep 2024 10:53:12 +0200
Subject: [PATCH] Added missing inView check
---
src/graph/GraphView.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/graph/GraphView.cpp b/src/graph/GraphView.cpp
index b203b60bb..d23137655 100644
--- a/src/graph/GraphView.cpp
+++ b/src/graph/GraphView.cpp
@@ -1416,7 +1416,7 @@ std::shared_ptr<Aidge::GraphView> Aidge::GraphView::cloneCallback(NodePtr(*clone
}
// For each node, convert old node -> new node connections
- for (auto &oldToNewNode : oldToNewNodes) {
+ for (const auto &oldToNewNode : oldToNewNodes) {
if (oldToNewNode.second == nullptr) {
continue; // deleted node
}
@@ -1424,7 +1424,7 @@ std::shared_ptr<Aidge::GraphView> Aidge::GraphView::cloneCallback(NodePtr(*clone
// Connect parent nodes. Nodes that were removed with cloneNode() are set to nullptr
size_t parentId = 0;
for (auto parent : oldToNewNode.first->inputs()) {
- if (parent.first != nullptr) {
+ if (parent.first != nullptr && inView(parent.first)) {
while (oldToNewNodes[parent.first] == nullptr) {
// Find next valid parent in line, going backward in the graph
AIDGE_INTERNAL_ASSERT(parent.first->getChildren().size() == 1);
@@ -1460,7 +1460,7 @@ std::shared_ptr<Aidge::GraphView> Aidge::GraphView::cloneCallback(NodePtr(*clone
newGraph->add(oldToNewNodes[mRootNode], false);
}
- for (auto &oldToNewNode : oldToNewNodes) {
+ for (const auto &oldToNewNode : oldToNewNodes) {
if (oldToNewNode.second == nullptr)
continue; // deleted node
--
GitLab