diff --git a/python_binding/backend/pybind_OperatorImpl.cpp b/python_binding/backend/pybind_OperatorImpl.cpp index 6a83805fc1af2e111dd1c9f49c669e0c2f9422aa..2819c78068cf7c64eeb0dca84de4518f1c6658b9 100644 --- a/python_binding/backend/pybind_OperatorImpl.cpp +++ b/python_binding/backend/pybind_OperatorImpl.cpp @@ -31,7 +31,7 @@ public: PYBIND11_OVERRIDE( void, OperatorImpl, - forward, + forward ); } @@ -39,7 +39,7 @@ public: PYBIND11_OVERRIDE( void, OperatorImpl, - backward, + backward ); } diff --git a/python_binding/data/pybind_Tensor.cpp b/python_binding/data/pybind_Tensor.cpp index d4d6edc9ca4d51eabe0665352997f5d5469bff74..73a55d46139435778308c8f066af3e8fc2e3256d 100644 --- a/python_binding/data/pybind_Tensor.cpp +++ b/python_binding/data/pybind_Tensor.cpp @@ -257,7 +257,7 @@ static void addScalarCtor(pyTensorClass& mTensor) { // though it is not merged: https://github.com/pybind/pybind11/pull/3544/. // Hence we use some helper functions defined above to try matching the different numpy scalar types. mTensor.def(py::init([](py::object obj, - const std::string backend="cpu") { + const std::string& backend = "cpu") { NativeValue native_val; DataType native_dtype; bool found = getScalarNativeVal(obj, &native_val, &native_dtype); @@ -283,7 +283,7 @@ static void addScalarCtor(pyTensorClass& mTensor) { template<typename T> void addArrayCtor(pyTensorClass& mTensor) { mTensor.def(py::init([](const py::array_t<T, py::array::c_style|py::array::forcecast> b, - const std::string backend = "cpu") { + const std::string& backend = "cpu") { /* Request a buffer descriptor from Python */ py::buffer_info info = b.request(); Tensor* newTensor = new Tensor(); diff --git a/python_binding/pybind_core.cpp b/python_binding/pybind_core.cpp index a9efa0538951087cd2e846b5b74017c36dc72f04..c72a629b24254a27cf7418af4f22c3df89084ad3 100644 --- a/python_binding/pybind_core.cpp +++ b/python_binding/pybind_core.cpp @@ -156,5 +156,6 @@ void init_Aidge(py::module& m) { init_Filler(m); } -PYBIND11_MODULE(aidge_core, m) { init_Aidge(m); } } // namespace Aidge + +PYBIND11_MODULE(aidge_core, m) { Aidge::init_Aidge(m); } diff --git a/src/graph/GraphView.cpp b/src/graph/GraphView.cpp index c9f3cd14db84dab0faab065278664e68fb577db6..b203b60bb32f0feb9b76d73cd6953cf81bea5e56 100644 --- a/src/graph/GraphView.cpp +++ b/src/graph/GraphView.cpp @@ -229,9 +229,7 @@ void Aidge::GraphView::setNodesName() const { std::map<std::string, std::int32_t> typeIds; for (const auto& nodePtr: getNodes()) { const std::string& t = nodePtr->getOperator()->type(); - if (typeIds.find(t) == typeIds.cend()) { - typeIds.emplace(t, 0); - } + typeIds.emplace(t, 0); const std::string nodeName = name() + std::string("_") + t + std::string("#") + std::to_string(typeIds[t]++); nodePtr->setName(nodeName); }