From 5e40685480cbb187b1d1f0adff6122663a47e4ea Mon Sep 17 00:00:00 2001
From: Jerome Hue <jerome.hue@cea.fr>
Date: Wed, 19 Feb 2025 15:00:12 +0100
Subject: [PATCH] Add backward step counter and backward() declaration for
stack op
---
include/aidge/operator/Stack.hpp | 23 +++++++++++++++++++++--
src/operator/Stack.cpp | 5 +++++
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/include/aidge/operator/Stack.hpp b/include/aidge/operator/Stack.hpp
index 214428447..83e4f68e1 100644
--- a/include/aidge/operator/Stack.hpp
+++ b/include/aidge/operator/Stack.hpp
@@ -89,10 +89,16 @@ public:
* @brief Executes the forward pass for the Stack operation.
*/
void forward() override;
+
+ /**
+ * @brief Executes the backward pass for the Stack operation.
+ */
+ void backward() override;
};
enum class StackAttr {
ForwardStep, // Tracks the current step in the forward pass.
+ BackwardStep, // Tracks the current step in the forward pass.
MaxElements // Maximum number of elements that can be stacked.
};
} // namespace Aidge
@@ -123,7 +129,7 @@ namespace Aidge {
class StackOp : public OperatorTensor,
public Registrable<StackOp, std::string, std::function<std::unique_ptr<OperatorImpl>(const StackOp&)>> {
private:
- using Attributes_ = StaticAttributes<StackAttr, std::uint32_t, std::uint32_t>;
+ using Attributes_ = StaticAttributes<StackAttr, std::uint32_t, std::uint32_t, std::uint32_t>;
template <StackAttr e> using attr = typename Attributes_::template attr<e>;
const std::shared_ptr<Attributes_> mAttributes;
@@ -181,6 +187,11 @@ public:
*/
void forward() override;
+ /**
+ * @brief Executes the backward pass for the `Stack` operation.
+ */
+ void backward() override;
+
/**
* @brief Access the operator's attributes.
* @return A shared pointer to the operator's attributes.
@@ -205,6 +216,15 @@ public:
return mAttributes->template getAttr<StackAttr::ForwardStep>();
}
+ /**
+ * @brief Get or set the backward step counter for the operator.
+ * @return A reference to the backward step counter.
+ */
+ inline std::uint32_t& backwardStep() const {
+ return mAttributes->template getAttr<StackAttr::BackwardStep>();
+ }
+
+
/**
* @brief Retrieve the names of the operator's input tensors.
* @return A vector of strings representing input tensor names.
@@ -239,5 +259,4 @@ public:
std::shared_ptr<Node> Stack(std::uint32_t maxElements = 0, const std::string& name = "");
} // namespace Aidge
-
#endif /* AIDGE_CORE_OPERATOR_STACK_H_ */
diff --git a/src/operator/Stack.cpp b/src/operator/Stack.cpp
index 17502e0f4..32a413174 100644
--- a/src/operator/Stack.cpp
+++ b/src/operator/Stack.cpp
@@ -61,10 +61,13 @@ void StackOpImpl::forward() {
op.forwardStep() * op.getInput(0)->size());
}
+void StackOpImpl::backward() {}
+
StackOp::StackOp(std::uint32_t maxElements)
: OperatorTensor(s_type, {InputCategory::Data, InputCategory::OptionalData}, 1),
mAttributes(std::make_shared<Attributes_>(
attr<StackAttr::MaxElements>(maxElements),
+ attr<StackAttr::BackwardStep>(0),
attr<StackAttr::ForwardStep>(0))) {
mImpl = std::make_shared<StackOpImpl>(*this);
}
@@ -136,6 +139,8 @@ void StackOp::forward() {
++forwardStep();
}
+void StackOp::backward() {}
+
std::shared_ptr<Node> Stack(std::uint32_t maxElements,
const std::string &name) {
return std::make_shared<Node>(std::make_shared<StackOp>(maxElements),
--
GitLab