From 2960fe6c63d5ed11cd35d6f37fc2bf3cc7d0f726 Mon Sep 17 00:00:00 2001
From: Octave Perrin <operrin@lrtechnologies.fr>
Date: Thu, 14 Nov 2024 14:26:08 +0100
Subject: [PATCH] more questions to ask
---
include/aidge/graph/GraphView.hpp | 2 +-
src/graph/GraphView.cpp | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/aidge/graph/GraphView.hpp b/include/aidge/graph/GraphView.hpp
index c18d91c2e..5bb17c0b3 100644
--- a/include/aidge/graph/GraphView.hpp
+++ b/include/aidge/graph/GraphView.hpp
@@ -659,7 +659,7 @@ private:
* inputs/outputs after adding this node.
* @param nodePtr
*/
- //@todo 100+ lines =(
+ //@todo 1see in code comment
void updateInputsOutputsNew(NodePtr newNode);
//@todo 100+ lines =(
diff --git a/src/graph/GraphView.cpp b/src/graph/GraphView.cpp
index 8440f22e8..444d6d856 100644
--- a/src/graph/GraphView.cpp
+++ b/src/graph/GraphView.cpp
@@ -1282,7 +1282,7 @@ void Aidge::GraphView::updateInputsOutputsNew(std::shared_ptr<Node> newNode) {
// Check that it was not already the case (if node UPDATE)
if (iter != mInputNodes.cend()) { // newNode is linked to an actual inputNode to an input connection
// The first old (removed) input becomes the insertion point for newNode GraphView inputs
- if (std::distance(newInputsInsertionPoint, iter) <= 0) {
+ if (std::distance(newInputsInsertionPoint, iter) <= 0) { //todo ask for dis part
newInputsInsertionPoint = mInputNodes.erase(iter);
}
else {
@@ -1360,7 +1360,7 @@ void Aidge::GraphView::updateInputsOutputsNew(std::shared_ptr<Node> newNode) {
break;
}
}
-
+// todo: from what i understood: for each output if at least one child is in the graph we don't add anything which is weird as an output could send to both in and out the graph
if (noInsideConnection) {
const auto val = std::make_pair(newNode, outputIdx);
// Output may be already be present (see addChild() with a node already in GraphView)
--
GitLab