From 02c2276f23e1785063a3b4eddd8e9c4013e0a161 Mon Sep 17 00:00:00 2001
From: cmoineau <cyril.moineau@cea.fr>
Date: Fri, 28 Feb 2025 15:17:27 +0000
Subject: [PATCH] Update some log messages and fix small typo in Node.hpp
---
include/aidge/graph/Node.hpp | 6 +++++-
src/graph/GraphView.cpp | 5 ++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/include/aidge/graph/Node.hpp b/include/aidge/graph/Node.hpp
index 9b16f76d5..15d8aaf4e 100644
--- a/include/aidge/graph/Node.hpp
+++ b/include/aidge/graph/Node.hpp
@@ -326,7 +326,7 @@ public:
* @param otherInId ID of the other Node input to connect to the current Node.
* Default to the first available data input.
*
- * @note otherNode shared_ptr is passed by refenrece in order to be able to detect
+ * @note otherNode shared_ptr is passed by reference in order to be able to detect
* possible dangling connection situations in debug using ref counting.
*/
void addChild(const NodePtr& otherNode,
@@ -507,7 +507,11 @@ private:
* @param outId
* @param otherInId
*
+<<<<<<< HEAD
* @note otherNode shared_ptr is passed by refenrece in order to be able to detect
+=======
+ * @note otherNode shared_ptr is passed by reference in order to be able to detect
+>>>>>>> 3a88aa7d (Update some log messages and fix small typo in Node.hpp)
* possible dangling connection situations in debug using ref counting.
*/
void addChildOp(const NodePtr& otherNode, const IOIndex_t outId,
diff --git a/src/graph/GraphView.cpp b/src/graph/GraphView.cpp
index 0e7951fe8..5d4df27a0 100644
--- a/src/graph/GraphView.cpp
+++ b/src/graph/GraphView.cpp
@@ -574,8 +574,7 @@ bool Aidge::GraphView::forwardDims(const std::vector<std::vector<Aidge::DimSize_
Log::debug("Trying to constant fold the graph");
// Shape are folded if we don't find back the node in the graph
if(constantFolding(shared_from_this(), true)){
- Log::notice("Shape node {} (of type {}) was folded.", nodePtr->name(), nodePtr->type());
- Log::debug("Resetting list of nodes to graph inputs");
+ Log::notice("Constant folding worked, resetting list of nodes to graph inputs.");
// Graph was modified during constant folding
// We re-propagate dims starting from the entry of the graph
nextList = inputNodes();
@@ -595,7 +594,7 @@ bool Aidge::GraphView::forwardDims(const std::vector<std::vector<Aidge::DimSize_
Log::debug("Breaking loop to restart from the beginning");
break;
}else{
- Log::debug("Shape node {} (of type {}) was not folded.", nodePtr->name(), nodePtr->type());
+ Log::debug("Constant folding fail to fold any nodes.");
}
}
// Recompute every time, even if it was already computed in a
--
GitLab