From d7cafea1be49987ceb7eda9d60d0ed5769f530c9 Mon Sep 17 00:00:00 2001
From: Jerome Hue <jerome.hue@cea.fr>
Date: Mon, 3 Mar 2025 09:21:44 +0100
Subject: [PATCH] Fix warnings by removing unused parameters in Add backward
kernel
---
include/aidge/backend/cpu/operator/AddImpl.hpp | 2 --
include/aidge/backend/cpu/operator/AddImpl_kernels.hpp | 4 ----
src/operator/AddImpl.cpp | 2 --
unit_tests/operator/Test_MetaOperator.cpp | 2 +-
4 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/include/aidge/backend/cpu/operator/AddImpl.hpp b/include/aidge/backend/cpu/operator/AddImpl.hpp
index ca04dff9..cfb85ecf 100644
--- a/include/aidge/backend/cpu/operator/AddImpl.hpp
+++ b/include/aidge/backend/cpu/operator/AddImpl.hpp
@@ -33,8 +33,6 @@ using AddImpl_cpu = OperatorImpl_cpu<Add_Op,
const std::vector<std::size_t>&,
const std::vector<std::size_t>&,
const void*,
- const void*,
- const void*,
void*,
void*)
>;
diff --git a/include/aidge/backend/cpu/operator/AddImpl_kernels.hpp b/include/aidge/backend/cpu/operator/AddImpl_kernels.hpp
index d6fff9b5..4be47849 100644
--- a/include/aidge/backend/cpu/operator/AddImpl_kernels.hpp
+++ b/include/aidge/backend/cpu/operator/AddImpl_kernels.hpp
@@ -154,15 +154,11 @@ void AddImpl_cpu_backward_kernel(const std::size_t input0Length,
const std::vector<std::size_t>& dims0,
const std::vector<std::size_t>& dims1,
const std::vector<std::size_t>& outputDims,
- const void* input0_,
- const void* input1_,
const void* grad_output_,
void* gradientInput0_,
void* gradientInput1_)
{
// TODO: Remove input0/1 from the function
- const I* input0 = static_cast<const I*>(input0_);
- const I* input1 = static_cast<const I*>(input1_);
const O* gradOutput = static_cast<const O*>(grad_output_);
auto* gradInput0 = static_cast<I*>(gradientInput0_);
auto* gradInput1 = static_cast<I*>(gradientInput1_);
diff --git a/src/operator/AddImpl.cpp b/src/operator/AddImpl.cpp
index b027fb87..cff61287 100644
--- a/src/operator/AddImpl.cpp
+++ b/src/operator/AddImpl.cpp
@@ -73,8 +73,6 @@ void Aidge::AddImpl_cpu::backward() {
in0->dims(),
in1->dims(),
out0grad->dims(),
- getCPUPtr(in0),
- getCPUPtr(in1),
getCPUPtr(out0grad),
getCPUPtr(in0grad),
getCPUPtr(in1grad));
diff --git a/unit_tests/operator/Test_MetaOperator.cpp b/unit_tests/operator/Test_MetaOperator.cpp
index 64c6886a..0c4a64bb 100644
--- a/unit_tests/operator/Test_MetaOperator.cpp
+++ b/unit_tests/operator/Test_MetaOperator.cpp
@@ -772,7 +772,7 @@ TEST_CASE("[cpu/operator] MetaOperator", "[MetaOperator][CPU]") {
}
const auto nbTimeSteps = dims[0];
- const auto beta = betaDist(gen);
+ const auto beta = betaDist(gen);
auto myLeaky = Leaky(nbTimeSteps, beta, 1.0, LeakyReset::Subtraction, "leaky");
auto op =
--
GitLab