From 23648f13cfd424d72a8f1d0ec38d25110c6eec8b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Kubler?= <gregoire.kubler@proton.me>
Date: Fri, 24 May 2024 17:16:29 +0200
Subject: [PATCH] fix : typo & left over dependency
---
CMakeLists.txt | 12 +-----------
setup.py | 1 -
2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2265a32e..276b5a30 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -19,16 +19,6 @@ execute_process(
OUTPUT_STRIP_TRAILING_WHITESPACE
ERROR_QUIET
)
-
-message(STATUS "Project name: ${CMAKE_PROJECT_NAME}")
-message(STATUS "Project version: ${version}")
-
-execute_process(
- COMMAND git rev-parse --short HEAD
- WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
- OUTPUT_VARIABLE GIT_COMMIT_HASH
- OUTPUT_STRIP_TRAILING_WHITESPACE
-)
message(STATUS "Latest git commit: ${GIT_COMMIT_HASH}")
# Define a preprocessor macro with the Git commit version
@@ -65,7 +55,7 @@ file(GLOB_RECURSE inc_files "include/*.hpp")
add_library(${module_name} ${src_files} ${inc_files})
target_link_libraries(${module_name}
PUBLIC
- _aidge_core # _ is added because we link the target not the project
+ _aidge_core # _ is added because we link the exported target and not the project
)
#Set target properties
diff --git a/setup.py b/setup.py
index e551567e..bd36e531 100644
--- a/setup.py
+++ b/setup.py
@@ -106,6 +106,5 @@ if __name__ == "__main__":
cmdclass={
"build_ext": CMakeBuild,
},
- install_requires=["aidge_core"],
zip_safe=False,
)
--
GitLab