From f44d261382b84e7aff94f9cb82a87bcaeaf16761 Mon Sep 17 00:00:00 2001
From: Olivier BICHLER <olivier.bichler@cea.fr>
Date: Thu, 12 Oct 2023 15:10:55 +0200
Subject: [PATCH] More fixes
---
.gitlab/ci/build.gitlab-ci.yml | 8 ++++----
include/aidge/operator/GenericOperator.hpp | 4 ++--
include/aidge/utils/DynamicAttributes.hpp | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/.gitlab/ci/build.gitlab-ci.yml b/.gitlab/ci/build.gitlab-ci.yml
index c4e66cfa2..79db04305 100644
--- a/.gitlab/ci/build.gitlab-ci.yml
+++ b/.gitlab/ci/build.gitlab-ci.yml
@@ -17,14 +17,14 @@ build:ubuntu_cpp:
- build_cpp/
- install_cpp/
-build:ubuntu_cpp_gcc10:
+build:ubuntu_cpp_g++10:
stage: build
needs: []
tags:
- docker
script:
- - apt install -y gcc-10
+ - apt install -y g++-10
- mkdir -p build_cpp
- mkdir -p install_cpp
- cd build_cpp
@@ -32,14 +32,14 @@ build:ubuntu_cpp_gcc10:
- cmake -DCMAKE_INSTALL_PREFIX:PATH=../install_cpp -DCMAKE_BUILD_TYPE=Debug -DWERROR=ON -DCOVERAGE=ON ..
- make -j4 all install
-build:ubuntu_cpp_gcc12:
+build:ubuntu_cpp_g++12:
stage: build
needs: []
tags:
- docker
script:
- - apt install -y gcc-12
+ - apt install -y g++-12
- mkdir -p build_cpp
- mkdir -p install_cpp
- cd build_cpp
diff --git a/include/aidge/operator/GenericOperator.hpp b/include/aidge/operator/GenericOperator.hpp
index 1e5186617..b86286eda 100644
--- a/include/aidge/operator/GenericOperator.hpp
+++ b/include/aidge/operator/GenericOperator.hpp
@@ -165,8 +165,8 @@ class GenericOperator_Op
~GenericOperator_Op() = default;
- void setBackend(const std::string & /*name*/) { printf("setBackend: not available yet.\n"); }
- void setDatatype(const DataType & /*datatype*/) { printf("setDatatype: not available yet.\n"); }
+ void setBackend(const std::string & /*name*/) override { printf("setBackend: not available yet.\n"); }
+ void setDatatype(const DataType & /*datatype*/) override { printf("setDatatype: not available yet.\n"); }
void forward() override final { printf("forward: not available yet.\n"); }
void backward() override final { printf("backward: not available yet.\n"); }
diff --git a/include/aidge/utils/DynamicAttributes.hpp b/include/aidge/utils/DynamicAttributes.hpp
index 60f586edf..af03ee286 100644
--- a/include/aidge/utils/DynamicAttributes.hpp
+++ b/include/aidge/utils/DynamicAttributes.hpp
@@ -194,7 +194,7 @@ public:
* generic type caster for std::any is not feasable.
* The strategy here is to keep a copy of each attribute in py::object that is updated everytime.
*/
- py::object getAttrPy(const std::string& name) const {
+ py::object getAttrPy(const std::string& name) const override final {
return mAttrsPy.at(name);
};
#endif
--
GitLab