From bfa7580b42676a1d3202289b40d23a6943f5c262 Mon Sep 17 00:00:00 2001
From: Olivier BICHLER <olivier.bichler@cea.fr>
Date: Fri, 1 Dec 2023 15:30:17 +0100
Subject: [PATCH] Removed [[deprecated]] but changed the name accordingly for
the CI to pass
---
include/aidge/graph/GraphView.hpp | 2 +-
src/graph/GraphView.cpp | 4 ++--
unit_tests/graph/Test_GraphView.cpp | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/aidge/graph/GraphView.hpp b/include/aidge/graph/GraphView.hpp
index c786ee1f3..3b3f9fb6d 100644
--- a/include/aidge/graph/GraphView.hpp
+++ b/include/aidge/graph/GraphView.hpp
@@ -454,7 +454,7 @@ protected:
* This function DOES NOT preserve inputs/outputs order and should NOT BE USED.
* It is here only to leave time to adapt the replace() function.
*/
- [[deprecated]] void updateInputsOutputsNodes();
+ void updateInputsOutputsNodes_DEPRECATED();
private:
///////////////////////////////////////////////////////
diff --git a/src/graph/GraphView.cpp b/src/graph/GraphView.cpp
index 9e5c1ef86..3b1a366f5 100644
--- a/src/graph/GraphView.cpp
+++ b/src/graph/GraphView.cpp
@@ -807,7 +807,7 @@ bool Aidge::GraphView::replace(const std::set<Aidge::NodePtr>& oldNodes, const s
graphPtr->add(newNodes, false);
if (newNodes.empty()) {
// TODO: FIXME: this function should not be called anymore!
- graphPtr->updateInputsOutputsNodes();
+ graphPtr->updateInputsOutputsNodes_DEPRECATED();
}
}
@@ -1028,7 +1028,7 @@ void Aidge::GraphView::updateInputsOutputsDelete(std::shared_ptr<Node> deletedNo
}
}
-void Aidge::GraphView::updateInputsOutputsNodes() {
+void Aidge::GraphView::updateInputsOutputsNodes_DEPRECATED() {
mInputNodes.clear();
for (const std::shared_ptr<Node>& go_ptr : mNodes) {
IOIndex_t inputIdx = 0;
diff --git a/unit_tests/graph/Test_GraphView.cpp b/unit_tests/graph/Test_GraphView.cpp
index 487c2dfef..392c24780 100644
--- a/unit_tests/graph/Test_GraphView.cpp
+++ b/unit_tests/graph/Test_GraphView.cpp
@@ -35,8 +35,8 @@ public:
// ctor
}
- void updateInputsOutputsNodes_Test() {
- GraphView::updateInputsOutputsNodes();
+ void updateInputsOutputsNodes_DEPRECATED_Test() {
+ GraphView::updateInputsOutputsNodes_DEPRECATED();
}
};
@@ -68,7 +68,7 @@ TEST_CASE("genRandomDAG") {
++nbUnicity;
// Test deprecated function
- g1->updateInputsOutputsNodes_Test();
+ g1->updateInputsOutputsNodes_DEPRECATED_Test();
// Check that inputs/outputs are the same regardless of the order
auto orderedInputs1 = nodePtrTo(g1->getOrderedInputs(), nodePtrToName);
auto orderedInputs2 = nodePtrTo(g2->getOrderedInputs(), nodePtrToName);
--
GitLab