From 53f7d1be8d741c8f97dfa4e185cb7850396e8fdf Mon Sep 17 00:00:00 2001
From: cmoineau <cyril.moineau@cea.fr>
Date: Wed, 7 Feb 2024 08:22:12 +0000
Subject: [PATCH] no c++ default args and kwargs not defined by py::arg.

---
 python_binding/operator/pybind_GenericOperator.cpp | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/python_binding/operator/pybind_GenericOperator.cpp b/python_binding/operator/pybind_GenericOperator.cpp
index e249e0f5d..6be4f31ac 100644
--- a/python_binding/operator/pybind_GenericOperator.cpp
+++ b/python_binding/operator/pybind_GenericOperator.cpp
@@ -33,18 +33,14 @@ void init_GenericOperator(py::module& m) {
             IOIndex_t nbData,
             IOIndex_t nbParam,
             IOIndex_t nbOut,
-            const std::string& name = "",
+            const std::string& name,
             const py::kwargs kwargs){
-            // std::string name = "";
-            // if (kwargs.contains("name")) {
-            //     name = kwargs["name"].cast<std::string>();
-            // }
             std::shared_ptr<Node> genericNode = GenericOperator(
                 type,
                 nbData,
                 nbParam,
                 nbOut,
-                std::move(name)
+                name
             );
             if (kwargs){
                 std::shared_ptr<GenericOperator_Op> gop = std::static_pointer_cast<GenericOperator_Op>(genericNode->getOperator());
@@ -55,6 +51,6 @@ void init_GenericOperator(py::module& m) {
                 }
             }
             return genericNode;
-        });
+        }, py::arg("type"), py::arg("nb_data"), py::arg("nb_param"), py::arg("nb_out"), py::arg("name") = "");
 }
 }  // namespace Aidge
-- 
GitLab