From 1245c82d26353bb91b72c1ef2d9a84a53f1bf025 Mon Sep 17 00:00:00 2001
From: Cyril Moineau <cyril.moineau@cea.fr>
Date: Wed, 17 Jan 2024 10:41:29 +0000
Subject: [PATCH] Add clarity to note on why we use a trampoline to bind
add_child.
---
python_binding/graph/pybind_Node.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/python_binding/graph/pybind_Node.cpp b/python_binding/graph/pybind_Node.cpp
index c4525dce8..83f5688fa 100644
--- a/python_binding/graph/pybind_Node.cpp
+++ b/python_binding/graph/pybind_Node.cpp
@@ -66,7 +66,8 @@ void init_Node(py::module& m) {
[](Node &self, std::shared_ptr<GraphView> other_graph, const IOIndex_t out_id=0,
py::object other_in_id = py::none()) {
std::pair<NodePtr, IOIndex_t> cpp_other_in_id;
- // Note: default arg nullptr to allow python binding
+ // Note: PyBind on windows does not support conversion of nullptr -> std::shared_ptr, using this trampoline to change the default arg to a py::none(). If signature change, we would be able to directly bind the function.
+
if (other_in_id.is_none()) {
cpp_other_in_id = std::pair<NodePtr, IOIndex_t>(nullptr, gk_IODefaultIndex);
}else{
--
GitLab