From cb632132d06dda3fa3554669482ecf53d61942c7 Mon Sep 17 00:00:00 2001
From: Islam Abed <islam.abed@partner.bmw.de>
Date: Thu, 28 Apr 2022 10:33:31 +0200
Subject: [PATCH] Address review comments
---
.../MantleAPI/Common/i_geometry_helper.h | 22 +++++++++----------
MantleAPI/test/MantleAPI/Test/test_utils.h | 6 ++---
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/MantleAPI/include/MantleAPI/Common/i_geometry_helper.h b/MantleAPI/include/MantleAPI/Common/i_geometry_helper.h
index 49992f8..32c35dd 100644
--- a/MantleAPI/include/MantleAPI/Common/i_geometry_helper.h
+++ b/MantleAPI/include/MantleAPI/Common/i_geometry_helper.h
@@ -41,23 +41,23 @@ public:
/// @brief Transforms world polyline positions to local coordinate system.
/// @param polyline_points world polyline points to be transformed
- /// @param position local system position
- /// @param orientation local system orientation
+ /// @param local_origin local coordinate system origin
+ /// @param local_orientation local system orientation
/// @return converted polyline points
virtual std::vector<Vec3<units::length::meter_t>> TransformPolylinePointsFromWorldToLocal(
const std::vector<Vec3<units::length::meter_t>>& polyline_points,
- const Vec3<units::length::meter_t>& position,
- const Orientation3<units::angle::radian_t>& orientation) const = 0;
+ const Vec3<units::length::meter_t>& local_origin,
+ const Orientation3<units::angle::radian_t>& local_orientation) const = 0;
/// @brief Transforms world position to local coordinate system.
- /// @param point_position world point position to be transformed
- /// @param position local system position
- /// @param orientation local system orientation
+ /// @param world_position world position to be transformed
+ /// @param local_origin local coordinate system origin
+ /// @param local_orientation local system orientation
/// @return transformed point
- virtual Vec3<units::length::meter_t> TransformPointPositionFromWorldToLocal(
- const Vec3<units::length::meter_t>& point_position,
- const Vec3<units::length::meter_t>& position,
- const Orientation3<units::angle::radian_t>& orientation) const = 0;
+ virtual Vec3<units::length::meter_t> TransformPositionFromWorldToLocal(
+ const Vec3<units::length::meter_t>& world_position,
+ const Vec3<units::length::meter_t>& local_origin,
+ const Orientation3<units::angle::radian_t>& local_orientation) const = 0;
};
} // namespace mantle_api
diff --git a/MantleAPI/test/MantleAPI/Test/test_utils.h b/MantleAPI/test/MantleAPI/Test/test_utils.h
index e6428c7..6fbc7e7 100644
--- a/MantleAPI/test/MantleAPI/Test/test_utils.h
+++ b/MantleAPI/test/MantleAPI/Test/test_utils.h
@@ -50,18 +50,18 @@ public:
const Vec3<units::length::meter_t>& position,
const Orientation3<units::angle::radian_t>& orientation) const
{
- // do not translate but return original points
+ // do not transform but return original points
std::ignore = position;
std::ignore = orientation;
return polyline_points;
}
- virtual Vec3<units::length::meter_t> TransformPointPositionFromWorldToLocal(
+ virtual Vec3<units::length::meter_t> TransformPositionFromWorldToLocal(
const Vec3<units::length::meter_t>& point_position,
const Vec3<units::length::meter_t>& position,
const Orientation3<units::angle::radian_t>& orientation) const
{
- // do not translate but return original points
+ // do not transform but return original points
std::ignore = position;
std::ignore = orientation;
return point_position;
--
GitLab